Skip to content

Conversation

Kyusung4698
Copy link
Contributor

  • added overwolf.settings.hotkey.update
  • updated global window to include typeof owad

@OdedItkinOW
Copy link
Contributor

OdedItkinOW commented Dec 6, 2022

for the 208 part - will be updated later this week most likely
for the ads part added afterwards - might have to roll back this one. as part of the ads sdk docs re-write (still under review), we're gonna overhaul the types to fit, but not sure just yet if I approve of this specific approach.

either way, thank you for the pr!

@Kyusung4698
Copy link
Contributor Author

Thanks for the review! I've reverted the owad changes. Feel free to merge whenever.

OdedItkinOW added a commit that referenced this pull request Feb 26, 2023
@OdedItkinOW
Copy link
Contributor

On hindsight most of this pr was applied already due to something else. Leaving it open since the Ads thing might still be a good idea to fix.

@OdedItkinOW OdedItkinOW changed the title v208 Add typeof owad May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants