[DC-142] chore: remove activity tab - unused post-oc10 #12307
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
chore/drop-activity-widget-2
branch
3 times, most recently
from
6396634 to
5a09f21
Compare
…ined class name + const adjustment
DeepDiver1975
force-pushed
the
chore/drop-activity-widget-2
branch
from
9268de0 to
4770bb9
Compare
| _localActivityWidget = new LocalActivityWidget(this); | ||
| _tab->addTab(_localActivityWidget, Resources::getCoreIcon(QStringLiteral("states/sync")), tr("Local Activity")); | ||
| auto _localActivityWidget = new LocalActivityWidget(this); | ||
| auto localActivityTabId = _tab->addTab(_localActivityWidget, Resources::getCoreIcon(QStringLiteral("states/sync")), tr("Local Activity")); |
There was a problem hiding this comment.
At the moment, no we don't need it but we have a member for the sync tab id so why not for the activity tab - this is why I made it a member. If neither is used get rid of both, otherwise I see no reason to have one index "saved" but not the other.
I am also not a fan of "auto" when the thing you are calling doesn't clearly indicate what type is returned.
There was a problem hiding this comment.
From my perspective the member can be added once needed - why carry around thing we don't need?
To me in this case both auto usages are quite clear - but I happily change if requested.
No description provided.