[DC-150] refactor Account shared pointer #12311
Draft
+309
−729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
refactored CheckServerJobFactory to take a raw account pointer. Also removed the parent arg to the factory as it's fairly useless adjusted the parenting of the one-off nam created in the factory to be sure it is parented by the job, so it is cleaned up along with the job. minimal update to oauth to deal with the new factory interface
also cleaned up some additional accessors in the abstract network job
…count, and got rid of account member for DiscoverySingleDirectoryJob as it was never used
… state to the spacesmanager as that was all that was needed eliminated more accessors to get the account, replaced more accountptr with just account*. identified cases where the account dep can be removed completely with correct refactoring to make jobs only run in controllers/managers (where it's reasonable). removed no longer used deprecated function from SpacesManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-150