parser: decorate parseable objects with attributes #14
+363
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancrossnyc
force-pushed
the
attributes
branch
from
082fd96 to
35f2d85
Compare
|
Thanks Dan! Are you planning on using RSF interfaces from Rust? If so we should probably add |
dancrossnyc
force-pushed
the
attributes
branch
from
35f2d85 to
f4faa63
Compare
|
I believe this is done; PTAL. |
|
Oops, there's a build failure. Huh; that's really weird. Ok, let me dig into that. |
At OxCon, Ry and I briefly spoke about how to gracefully accommodate the need to inject additional data into rsf so that, for example, one could specify how to format a field, as some AMD registers report things like power or voltage or current in odd units (such as eights of a volt or similar) and it would be nice to normalize those into a standard unit. One could image doing this with something like a snippet of rhai code, but then how would one inject that into an rsf specification? Ry suggested using attributes; this introduces a familiar `#[attr(id = "string")]` syntax and corresponding parser support for such constucts.
dancrossnyc
force-pushed
the
attributes
branch
from
f4faa63 to
a8e5c6e
Compare
Yup. I neglected to run tests with the "test generated code" feature. Should be fixed now. My bad! |
|
Thanks, Ry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At OxCon, Ry and I briefly spoke about how to gracefully accommodate the need to inject additional data into rsf so that, for example, one could specify how to format a field, as some AMD registers report things like power or voltage or current in odd units (such as eights of a volt or similar) and it would be nice to normalize those into a standard unit. One could image doing this with something like a snippet of rhai code, but then how would one inject that into an rsf specification?
Ry suggested using attributes; this introduces a familiar
#[attr(id = "string")]syntax and corresponding parser support for such constucts.