-
Notifications
You must be signed in to change notification settings - Fork 7
chore(deps): bumped go version #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe Go toolchain version in go.mod was updated from 1.24 to 1.25. No other files or dependencies were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
3-3
: Optional: consider pinning the toolchain for reproducible local builds.If you want consistent local/CI behavior, add a toolchain line (use latest patch) after the go directive. Otherwise skip to keep auto-upgrades. (go.dev)
Apply if desired:
module github.com/ozontech/seq-db go 1.25 +toolchain go1.25.1
Also run: go mod tidy -go=1.25 to refresh sums and ensure the module graph matches the new language version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
go.mod
(1 hunks)
🔇 Additional comments (1)
go.mod (1)
3-3
: Approve — Go 1.25 in go.mod; confirm CI/Docker/dev images use Go 1.25.xgo.mod contains "go 1.25" (line 3); repo-wide search found no 1.24 pins.
No .github/workflows, Dockerfile*, Makefile, or .tool-versions found to validate CI/toolchain — confirm external/org CI, Dockerfiles, and setup‑go steps are set to golang:1.25 or setup‑go 1.25.x.
Hey! Thanks for the contribution. Please fix following things:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
- Coverage 71.52% 71.43% -0.09%
==========================================
Files 201 200 -1
Lines 18170 18143 -27
==========================================
- Hits 12996 12961 -35
- Misses 4455 4462 +7
- Partials 719 720 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Bumped go version
Fixes #121
If you have used LLM/AI assistance please provide model name and full prompt:
Summary by CodeRabbit