-
Notifications
You must be signed in to change notification settings - Fork 8
feat: support compatibility with nanosecond MID precision (phase 1) #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cheb0
wants to merge
29
commits into
main
Choose a base branch
from
232-nanos-support-phase-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+354
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microseconds compatibility (cast to milliseconds)
# Conflicts: # frac/meta_data_collector.go
…will always store milliseconds)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 71.88% 71.73% -0.16%
==========================================
Files 199 199
Lines 14570 14700 +130
==========================================
+ Hits 10474 10545 +71
- Misses 3362 3412 +50
- Partials 734 743 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The is the intermediate version for supporting nanosecond MID. This version still operates in millisecond MIDs, but is compatible with the current (main) version as well as with future (phase 2) version where
seq.MIDcontains nanoseconds. This allows us to rollback in case of problem with the future version.seq.MIDare still in milliseconds.seq.MIDare in nanoseconds. This version silently converts them to millisecondsseq.MIDin nanoseconds. This version converts them to milliseconds as well.seq.MIDinside stored JSON. If we see a different version (naonseconds), we convert them to millis and change version.seq.MIDand we can not change versions.seq.IDstring representation is added. If MID is in nanoseconds, then delimiter is_instead of-. In this version, if we see_delimiter, then we convert to milliseconds.Relates to #232
If you have used LLM/AI assistance please provide model name and full prompt: