Extend CopyStructures to optionally copy tuples #5364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-copytuple
branch
from
e638f71 to
e88a6c9
Compare
fruffy
approved these changes
Sep 12, 2025
| public: | ||
| explicit CopyStructures(TypeMap *typeMap, bool errorOnMethodCall = true, | ||
| bool copyHeaders = false, TypeChecking *typeChecking = nullptr) { | ||
| bool copyHeaders = false, bool copyTuples = false, |
There was a problem hiding this comment.
Would consider converting this into an option struct. Now that we have C++20 we can also use designated initializers
fruffy
added
the
core
ChrisDodd
force-pushed
the
cdodd-copytuple
branch
from
e88a6c9 to
9deae97
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
ChrisDodd
force-pushed
the
cdodd-copytuple
branch
from
9deae97 to
f80943b
Compare
Signed-off-by: Chris Dodd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some targets/backends, it does not really make sense to convert tuples into structs, but it may be necessary to split up tuple copies into separate copies for each element of the tuple. This change adds that capability to CopyStructures.