Refactor: Replace javascript:void(0) with # for CSP compliance #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElLorans
reviewed
Jun 15, 2025
There was a problem hiding this comment.
what is this file's purpose?
There was a problem hiding this comment.
It gets created/managed by the tests somehow - I think if tests fail in some ways it doesn't get cleaned up properly. Probably should be .gitignored.
There was a problem hiding this comment.
This file is an artifact from a previously failed test. All tests are passing now, so I don’t think we should add it to .gitignore - tests should pass before a PR is merged.
UPD
The file was removed.
I've replaced all instances of `javascript:void(0)` in href attributes with `#` within the Bootstrap 4 templates. This change is part of the effort to make the package more Content Security Policy (CSP) compliant. Existing JavaScript `onclick` handlers are preserved, and the use of `#` as the href value for links that primarily trigger JavaScript actions or serve as placeholders should not impact functionality. I manually tested dropdowns, actions, and pagination and confirmed that they continue to work as expected. I also ran automated tests, and all tests passed.
bubanoid
force-pushed
the
csp-compliance-javascript-void
branch
from
b578421 to
a4b94bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced all instances of
javascript:void(0)in href attributes with#within the Bootstrap 4 templates. Also, the instance ofjavascript:void(0)in theflask_admin/static/vendor/select2/select2.min.jswas replaced with#. This change is part of the effort to make the package more Content Security Policy (CSP) compliant.Existing JavaScript
onclickhandlers are preserved, and the use of#as the href value for links that primarily trigger JavaScript actions or serve as placeholders should not impact functionality.I manually tested dropdowns, actions, and pagination and confirmed that they continue to work as expected. I also ran automated tests, and all tests passed.