CLN: Replace warnings with Pandas4Warning #62162
Merged
+167
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/arrow/array.py
Outdated
| @@ -930,6 +930,7 @@ def _logical_method(self, other, op) -> Self: | |||
| and isinstance(other, np.ndarray) | |||
| and other.dtype == bool | |||
| ): | |||
| # TODO: Enforce in 3.0 (#60234) | |||
There was a problem hiding this comment.
Not sure if this one should already be enforced?
There was a problem hiding this comment.
Yea, agreed. I've changed this to Pandas4Warning and moved the deprecation from the 3.0 issue to the 4.0 issue.
5 tasks
mroeschke
approved these changes
Aug 25, 2025
|
Thanks @rhshadrach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Replaces all appropriate FutureWarnings and DeprecationWarnings with Pandas4Warnings. For those that are to be enforced in 3.0, I added
# TODO: Enforce .... I plan to introduce linting rules on FutureWarning/DeprecationWarning next.