Skip to content

REF: use _cast_pointwise_result in map #62177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

REF: use _cast_pointwise_result in map #62177

wants to merge 1 commit into from
+6 −3

Conversation

NevroHelios
Copy link

@NevroHelios
Copy link
Author

Hi @jbrockmendel ,
I’ve updated the code so that it now preserves the original dtype. Because of this, some of the existing type-checking tests are failing — they were written for the old behavior. These tests might need to be updated to reflect the new semantics. Could you let me know if adjusting them in this way makes sense?

@jbrockmendel
Copy link
Member

Please use your best judgement.

@NevroHelios
Copy link
Author

Okay, thanks.. I’ll update the tests to keep things consistent and aligned with user expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REF: use _cast_pointwise_result in map
2 participants
@NevroHelios @jbrockmendel