CI: Fix scripts tests when running from another directory #62181
+27
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Testing
rhshadrach
commented
Aug 24, 2025
| @@ -10,7 +10,7 @@ class TestStringsWithWrongPlacedWhitespace: | |||
| "data", | |||
| [ | |||
| ( | |||
| """ | |||
| r""" | |||
There was a problem hiding this comment.
Noticed that without having this as a raw string, the test will fail on Python 3.12.
rhshadrach
changed the title
mroeschke
reviewed
Aug 25, 2025
mroeschke
reviewed
Aug 25, 2025
| @@ -10,34 +10,36 @@ | |||
| pin_min_versions_to_yaml_file, | |||
| ) | |||
|
|
|||
| BASE_PATH = pathlib.Path(__file__).parents[2] | |||
There was a problem hiding this comment.
Might be more robust to define pathlib.Path("scripts/tests/data/").resolve() that can be used for the test below
There was a problem hiding this comment.
Made an update here to use DATA_PATH with scripts/test/data appended. But we don't want to use pathlib.Path("scripts/tests/data/") as that would only be correct if you're running the test from the root directory of the repo.
mroeschke
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.scripts/tests fail when you don't run from the root directory of the repository.