Skip to content

fix: Inline value match in SparseTrie::find_leaf to remove redundant wrapper #19138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 31, 2025
+1 −0
Merged

fix: Inline value match in SparseTrie::find_leaf to remove redundant wrapper #19138

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1201082
Update trie.rs
anim001k Oct 20, 2025
ced8b8e
Update trie.rs
anim001k Oct 20, 2025
26c69a5
Update trie.rs
anim001k Oct 20, 2025
ae2e0ba
Update trie.rs
anim001k Oct 21, 2025
74a64a7
Update trie.rs
anim001k Oct 21, 2025
089ff26
Update trie.rs
anim001k Oct 24, 2025
99a28fc
Update trie.rs
anim001k Oct 24, 2025
2512e5e
Update trie.rs
anim001k Oct 24, 2025
09a7af8
Merge remote-tracking branch 'origin/main' into patch-11
shekhirin Oct 31, 2025
fd4f7d1
remove unrelated changes
shekhirin Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/trie/sparse/src/trie.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,6 +974,7 @@ impl SparseTrieInterface for SerialSparseTrie {
expected_value: Option<&Vec<u8>>,
) -> Result<LeafLookup, LeafLookupError> {
// Helper function to check if a value matches the expected value
#[inline]
fn check_value_match(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just add an #[inline] attribute here? It doesn't clone the value unless the error is returned anyway, as @mediocregopher said.

actual_value: &Vec<u8>,
expected_value: Option<&Vec<u8>>,
Expand Down