Skip to content

fix: remove unnecessary trait bounds in extend_sorted_vec helper #19154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

fix: remove unnecessary trait bounds in extend_sorted_vec helper #19154

merged 1 commit into from
Oct 21, 2025
+1 −1

Conversation

@maradini77
Copy link
Contributor

Description

  • Summary: Remove unused and redundant trait bounds to simplify the API and improve reusability.
  • Rationale: The function doesn't use hashing, so Hash bound is unnecessary. Eq is redundant since Ord already implies Eq.
  • Changes:
    • Remove core::hash::Hash + Eq bounds from key type K
    • Keep only Clone + Ord which are actually required for the merge logic

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Oct 20, 2025
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 21, 2025
@mediocregopher mediocregopher added this pull request to the merge queue Oct 21, 2025
Merged via the queue into paradigmxyz:main with commit 6456729 Oct 21, 2025
41 of 42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mediocregopher mediocregopher mediocregopher approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maradini77 @mediocregopher