Skip to content

Governance pre compile - Referenda & Conviction Voting #10107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Governance pre compile - Referenda & Conviction Voting #10107

wants to merge 22 commits into from
+561 −0

Conversation

@LucasGrasso
Copy link

@LucasGrasso LucasGrasso commented Oct 23, 2025 •
edited
Loading

Description

Implements the referenda-precompiles and conviction-voting-precomples as components of the Governance Precompile.
Addresses #8366.

Integration

It does not pose any breaking changes. It publishes the referenda-precompiles and conviction-voting-precomples crates.

Review Notes

Please see our Bounty Proposal.

Milestone 1 Work

Checklist

  • My PR includes a detailed description as outlined in the "Description" and its two subsections above.
  • My PR follows the labeling requirements of this project (at minimum one label for T required)
    • External contributors: Use /cmd label <label-name> to add labels
    • Maintainers can also add labels manually
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Implement ConvictionVotingPrecompile
  • Test ConvictionVotingPrecompile
  • Benchmark ConvictionVotingPrecompile
  • Implement ReferendaPrecompile
  • Test ReferendaPrecompile
  • Benchmark ReferendaPrecompile

EmanHerawy and others added 21 commits October 14, 2025 18:24
@EmanHerawy @LucasGrasso @Ank4n
Add initial proposal draft with Governance Precompile interface design
d694c32 
Co-authored-by: Lucas Grasso <[email protected]>
Co-authored-by: Ankan <[email protected]>
@LucasGrasso
governance-precompiles: add cargo.toml and lib.rs
cc3f4f4
@LucasGrasso
governance-precompile: update interface
ea1f3e9
@LucasGrasso
docs(IReferenda.sol): add descriptions for the GovernanceOrigin enum
c94c472
@EmanHerawy
update the propsoal with minimal interface design
32c9513
@LucasGrasso
docs(Minimal governance precompiles): add natspec documentation
1ffabb5
@LucasGrasso
refactor(governance-precompile): remove outdated code, and fine-grain…
c70dfee 
…ed proposal
@LucasGrasso
refacotr(governance-precompile): move to separate crates
d947518
@LucasGrasso
refactor(governance-precompile): update interfaces
88c594e
@LucasGrasso
docs(governance-precompiles): minor modifications to @title
dffa202
@LucasGrasso
Merge pull request #1 from EmanHerawy/separate-governance-precompiles
27f3f74 
Separate precompile crates
@LucasGrasso
docs(referena-precompiles): state purpose of Ireferenda
73c5382
@LucasGrasso
refactor(IReferenda.sol): remove support in getReferendumTally as to …
fa791a6 
…support various Tally impls
@LucasGrasso
docs(IReferenda.sol): revert @dev
62fe7c2
@LucasGrasso
refactor(governance-precompile): move tally query to conviction voting
56412ae
@LucasGrasso
refactor(governance-precompile): add refund functions
1236dc6
@LucasGrasso
refactor(governance-precompiles): refactor submit origins and add docs
dd671ca
@LucasGrasso
feat(IReferenda.sol): decision deposit getter
15c6892
@EmanHerawy
Merge pull request #2 from EmanHerawy/abstract-referenda-precompile
bed1f5e 
Abstract referenda precompile
@LucasGrasso
refactor(ICOnvictionVoting): bytes32 -> address for account type
55c8775
@LucasGrasso
Merge branch 'paritytech:master' into governance-pre-compile
1478dd2
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 23, 2025

User @EmanHerawy, please sign the CLA here.

User @LucasGrasso, please sign the CLA here.

@LucasGrasso
Copy link
Author

/cmd label T7-smart_contracts

@LucasGrasso
Copy link
Author

/cmd label C3-og-rust-bounty

@github-actions
Copy link
Contributor

Command "label T7-smart_contracts" has failed ❌! See logs here

@github-actions
Copy link
Contributor

Command "label C3-og-rust-bounty" has failed ❌! See logs here

@franciscoaguirre franciscoaguirre added T7-smart_contracts This PR/Issue is related to smart contracts. C3-og-rust-bounty A task rewarded by the OG Rust bounty for successful completion. See https://ogrust.com/ labels Oct 24, 2025
@Ank4n
Copy link
Contributor

Ank4n commented Oct 30, 2025

@pgherveou @athei Could you guys give a quick feedback if the interfaces/general direction looks good? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

C3-og-rust-bounty A task rewarded by the OG Rust bounty for successful completion. See https://ogrust.com/ T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LucasGrasso @Ank4n @franciscoaguirre @EmanHerawy