Skip to content

fix: Event not presented to client when __type is missing in LiveQuery server response #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Event not presented to client when __type is missing in LiveQuery server response #1863

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18003b0
Workaround to fix parsing when afterLiveQueryEvent is active on server
ashish-naik Sep 27, 2025
eeebc5b
LiveryQuery server response sends data or events in "object":jsonf= f…
ashish-naik Sep 28, 2025
07b9c62
Inject __type = @"Object" if missing but className/objectId present a…
ashish-naik Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Parse/Parse/Source/PFDecoder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ - (id)decodeDictionary:(NSDictionary *)dictionary {
}

NSString *type = dictionary[@"__type"];
// Inject __type = @"Object" if missing but className/objectId present
if (!type && dictionary[@"className"] && dictionary[@"objectId"]) {
NSMutableDictionary *mutable = [dictionary mutableCopy];
mutable[@"__type"] = @"Object";
type = @"Object";
dictionary = mutable;
}
if (type) {
if ([type isEqualToString:@"Date"]) {
return [[PFDateFormatter sharedFormatter] dateFromString:dictionary[@"iso"]];
Expand Down
1 change: 0 additions & 1 deletion ParseLiveQuery/ParseLiveQuery/Internal/ClientPrivate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ private func parseObject<T: PFObject>(_ objectDictionary: [String:AnyObject]) th
guard let _ = objectDictionary["objectId"] as? String else {
throw LiveQueryErrors.InvalidJSONError(json: objectDictionary, expectedKey: "objectId")
}

guard let object = PFDecoder.object().decode(objectDictionary) as? T else {
throw LiveQueryErrors.InvalidJSONObject(json: objectDictionary, details: "cannot decode json into \(T.self)")
}
Expand Down