Skip to content

Update golangci-lint #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update golangci-lint #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9f165
Update `golangci-lint`
joshuaspence Nov 22, 2024
5f4b54c
Update `golangci-lint` configuration
joshuaspence Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
32 changes: 15 additions & 17 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
---
linters:
disable-all: true
enable:
- "gofmt"
- "gosimple"
- "govet"
- "ineffassign"
- "makezero"
- "misspell"
- "nakedret"
- "nilerr"
- "staticcheck"
- "structcheck"
- "unconvert"
- "unused"

run:
timeout: '5m'
enable-all: true
disable:
# Temporary
#- 'depguard'
#- 'gomoddirectives'
#- 'nosnakecase'
#- 'paralleltest'
#- 'persprintf'
#- 'thelper'
#- 'varnamelen'
#- 'wrapcheck'
#- 'wsl'

# Deprecated
- 'exportloopref'
205 changes: 102 additions & 103 deletions go.mod
View file
Open in desktop

Large diffs are not rendered by default.

791 changes: 220 additions & 571 deletions go.sum
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion internal/provider/data_account_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ package provider

import (
"fmt"
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"testing"

"github.com/hashicorp/terraform-plugin-testing/helper/resource"
)

func TestAccDataAccount_default(t *testing.T) {
Expand Down
4 changes: 1 addition & 3 deletions internal/provider/data_user_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ func TestAccDataUser_default(t *testing.T) {

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
//preCheck(t)

_, err := testClient.CreateUser(context.Background(), "default", &unifi.User{
MAC: mac,
Name: "tfacc-User-Data",
Expand All @@ -26,7 +24,7 @@ func TestAccDataUser_default(t *testing.T) {
t.Fatal(err)
}
},
//PreCheck: func() { preCheck(t) },
// PreCheck: func() { preCheck(t) },
ProviderFactories: providerFactories,
Steps: []resource.TestStep{
{
Expand Down
Loading
Loading