fix: prevent stale data when using the back button (fixes #12914) #13371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rit3sh-x
requested review from
jacobsfletch,
AlessioGr and
JarrodMFlesch
as code owners
rit3sh-x
changed the title
|
Any suggestions? |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a browser cache issue where stale data was displayed when using the back button after database updates. The fix adds a router.refresh() call to force the page to reload and reflect the latest state after successful form submissions.
- Adds
router.refresh()call after successful form submissions when no redirect is specified - Updates TypeScript type definitions to change ID types from
numbertostring
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui/src/forms/Form/index.tsx | Adds router refresh to invalidate client-side cache after form submission |
| test/_community/payload-types.ts | Updates ID type definitions from number to string across all entity interfaces |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Refresh the screen always to reset the cache Co-authored-by: Copilot <[email protected]>
|
Is this correct now? or should I resolve it any other way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser showed stale data when using the back button after making changes to the database. This happened because the browser's bfcache was restoring the previous state instead of fetching the updated data.
To solve this, I added a router.refresh() after the database update to force the page to reload and reflect the latest state. This is a reliable temporary fix, but I understand that it increases backend calls. I'm planning to improve this further by removing the refresh and implementing a more efficient, reactive solution.
Fixes #12914