vendor: Bump extsort version #841
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonWizard
requested review from
igungor and
seruman
and removed request for
a team
NeonWizard
force-pushed
the
bump-extsort-version
branch
from
63dabd4 to
96e3841
Compare
NeonWizard
force-pushed
the
bump-extsort-version
branch
from
96e3841 to
9fc06ab
Compare
NeonWizard
commented
Oct 7, 2025
| # github.com/lanrat/extsort v1.0.2 | ||
| ## explicit; go 1.13 | ||
| # github.com/lanrat/extsort v1.4.2 | ||
| ## explicit; go 1.23 |
There was a problem hiding this comment.
Unfortunately, looks like the Go version in extsort was bumped in version v1.2.0. s5cmd would need to also update Go to 1.23 to take in this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
lanrat/extsortversion to fix a panic:lanrat/extsort#10
tl;dr:
This panic is caused when running
s5cmdwithout enough memory, causing a fallback to extsort, and also running out of storage space in/tmp.