Update dependencies #115
Open
Update dependencies #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyliu-q
reviewed
Dec 17, 2021
| @@ -6,8 +6,7 @@ | |||
| "extends": [ | |||
| "airbnb", | |||
| "react-app", | |||
| "prettier", | |||
| "prettier/react" | |||
| "prettier" | |||
There was a problem hiding this comment.
Why did you remove prettier/react? Looks like this is accessing additional prettier config specific to react: https://eslint.org/docs/developer-guide/shareable-configs#sharing-multiple-configs
There was a problem hiding this comment.
Turns out prettier/react was merged into prettier so this is no longer necessary since 8.0
|
React checks are passing - I did not bump SWR since their API changes are non-trivial and we have to revisit it in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So dependabot stops emailing me all the time.