K8SPSMDB-1197: fix healthcheck log rotation #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
size/XXL
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pooknull
requested review from
hors,
egegunes,
nmarukovich and
gkech
as code owners
gkech
reviewed
Feb 14, 2025
| "github.com/go-logr/logr" | ||
| uzap "go.uber.org/zap" | ||
| "go.uber.org/zap/zapcore" | ||
| "gopkg.in/natefinch/lumberjack.v2" |
There was a problem hiding this comment.
Shouldn't we use "github.com/percona/percona-server-mongodb-operator/cmd/mongodb-healthcheck/logger/lumberjack"here?
There was a problem hiding this comment.
Just noticed we are replacing the dependency with the local directory. We are good then!
gkech
previously approved these changes
Feb 17, 2025
egegunes
approved these changes
Feb 20, 2025
Comment on lines
4
to
6
| COPY go.mod go.sum ./ | ||
| RUN go mod download | ||
|
|
There was a problem hiding this comment.
why do we need this change? with this we'll need to download modules after a every code change
egegunes
requested changes
Feb 20, 2025
This reverts commit 90755fe.
gkech
approved these changes
Feb 24, 2025
github-actions
bot
added
the
dependencies
commit: b112ff3 |
egegunes
approved these changes
Feb 27, 2025
hors
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-1197
DESCRIPTION
Problem:
healthcheckdoesn't delete old logs if executed very quickly.Cause:
lumberjack rotates logs in the separate goroutine. It's not guaranteed to finish and it's not possible to check if it's finished.
Solution:
Replace current version of
lumberjackwith natefinch/lumberjack#211.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability