K8SPS-550: apply serviceAccountName for haproxy pods

[pooknull]

https://perconadev.atlassian.net/browse/K8SPS-550

DESCRIPTION

Problem:
serviceAccountName is not applied to the HAProxy statefulset.

Solution:
This is a common bug where some fields from the PodSpec are not applied to statefulsets. To fix this, the (s *PodSpec) Core method was created to return a corev1.PodSpec with all fields populated.

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported PS version?
• Does the change support oldest and newest supported Kubernetes version?

[gkech]

Here we can do assert.Empty(t, sts.Spec.Template.Spec.ServiceAccountName) instead.

[pooknull]

1050a29

[gkech]

Here we can do assert.Empty(t, sts.Spec.Template.Spec.ServiceAccountName) instead.

[pooknull]

1050a29

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[JNKPercona]

Test Name	Result	Time
version-service-8-4	passed	00:00:00
async-ignore-annotations-8-4	passed	00:00:00
async-global-metadata-8-4	passed	00:00:00
auto-config-8-4	passed	00:00:00
config-8-4	passed	00:00:00
config-router-8-0	passed	00:00:00
config-router-8-4	passed	00:00:00
demand-backup-minio-8-0	passed	00:00:00
demand-backup-minio-8-4	passed	00:00:00
demand-backup-cloud-8-4	passed	00:00:00
async-data-at-rest-encryption-8-0	passed	00:00:00
async-data-at-rest-encryption-8-4	passed	00:00:00
gr-global-metadata-8-4	passed	00:00:00
gr-data-at-rest-encryption-8-0	passed	00:00:00
gr-data-at-rest-encryption-8-4	passed	00:00:00
gr-demand-backup-minio-8-4	passed	00:00:00
gr-demand-backup-cloud-8-4	passed	00:00:00
gr-demand-backup-haproxy-8-4	passed	00:00:00
gr-finalizer-8-4	passed	00:00:00
gr-haproxy-8-0	passed	00:00:00
gr-haproxy-8-4	passed	00:00:00
gr-ignore-annotations-8-4	passed	00:00:00
gr-init-deploy-8-0	passed	00:00:00
gr-init-deploy-8-4	passed	00:00:00
gr-one-pod-8-4	passed	00:00:00
gr-recreate-8-4	passed	00:00:00
gr-scaling-8-4	passed	00:00:00
gr-scheduled-backup-8-4	passed	00:00:00
gr-security-context-8-4	passed	00:00:00
gr-self-healing-8-4	passed	00:00:00
gr-tls-cert-manager-8-4	passed	00:00:00
gr-users-8-4	passed	00:00:00
haproxy-8-0	passed	00:00:00
haproxy-8-4	passed	00:00:00
init-deploy-8-0	passed	00:00:00
init-deploy-8-4	passed	00:00:00
limits-8-4	passed	00:00:00
monitoring-8-4	passed	00:00:00
one-pod-8-0	passed	00:00:00
one-pod-8-4	passed	00:00:00
operator-self-healing-8-4	passed	00:00:00
pvc-resize-8-4	passed	00:00:00
recreate-8-4	passed	00:00:00
scaling-8-4	passed	00:00:00
scheduled-backup-8-0	passed	00:00:00
scheduled-backup-8-4	passed	00:18:38
service-per-pod-8-4	passed	00:00:00
sidecars-8-4	passed	00:00:00
smart-update-8-4	passed	00:00:00
storage-8-4	passed	00:00:00
telemetry-8-4	passed	00:00:00
tls-cert-manager-8-4	passed	00:00:00
users-8-0	passed	00:00:00
users-8-4	passed	00:00:00

Summary	Value
Tests Run	54/54
Job Duration	01:02:52
Total Test Time	00:18:38

commit: 8877131
image: perconalab/percona-server-mysql-operator:PR-1098-88771311