Skip to content

Make CI fail on go compilation errors #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Draft

Make CI fail on go compilation errors #897

wants to merge 2 commits into from

Conversation

artemgavrilov
Copy link
Contributor

  • The contributed code is licensed under GPL v2.0
  • Contributor Licence Agreement (CLA) is signed
  • util/update-modules has been ran
  • Documentation updated
  • Test suite update

@it-percona it-percona temporarily deployed to fix-go-ci - percona-toolkit PR #897 December 17, 2024 23:02 — with Render Destroyed
svetasmirnova
svetasmirnova requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@svetasmirnova svetasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is encrypt.go part of this patch or is it supposed to be part of PR-896?

@artemgavrilov
Copy link
Contributor Author

This is still Draft, not ready for review. It's unrelated to #896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svetasmirnova svetasmirnova svetasmirnova requested changes

@EvgeniyPatlan EvgeniyPatlan EvgeniyPatlan approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artemgavrilov @svetasmirnova @EvgeniyPatlan @it-percona