PG-1879 Clean up makefile before repo split #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
force-pushed
the
tde/split-make-cleanup
branch
from
cf8a199 to
29061e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (84.20%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #581 +/- ##
==================================================
Coverage 84.20% 84.20%
==================================================
Files 25 25
Lines 3247 3247
Branches 511 511
==================================================
Hits 2734 2734
Misses 400 400
Partials 113 113
🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
tde/split-make-cleanup
branch
2 times, most recently
from
9c9cb53 to
d081540
Compare
jeltz
changed the title
jeltz
force-pushed
the
tde/split-make-cleanup
branch
from
d081540 to
5fb9561
Compare
Warnings from libkmip were previously only silenced in Meson builds.
There is no reaosn to user override and appending for everything. PostgreSQL themselves only use it for things like CFLAGS where the user is expected to specify their own stuff.
This mirrors how it is done in other parts of PostgreSQL where meson uses the .o object directly while Make uses libpgutils.a.
The output spam from make makes it hard to find errors when the build fails.
jeltz
force-pushed
the
tde/split-make-cleanup
branch
from
5fb9561 to
0c18c4d
Compare
When linking the define is ignored anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various clean ups of the makefile to make it easier to turn
pg_tdeinto an external extensions.overrideand+=libkmiplibpgfeutils.awhen building command line tools