forked from samcamwilliams/HyperBEAM
-
Couldn't load subscription status.
- Fork 67
impr: bump LMDB by adopting lmdb-master-sys #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jyeshe
wants to merge
5
commits into
edge
Choose a base branch
from
bump-lmdb
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
|
|
@twilson63 it's reverted here to use the DEFAULT_SIZE. |
* chore: allow LMDB to flush to disk This is important as the database is opened with NO_SYNC * chore: handle app stop callbacks to flush and close LMDB
|
@samcamwilliams this is rebased and tested again with one process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
elmdb-rswill now depend onlmdb-master-rs, a fork oflmdb-rsthat useslmdb-master-sys.It has the FOR-141 merged on it to avoid loosing data of huge hydrations after restarting HB frequently.