Skip to content

Conversation

@tavallaie
Copy link
Collaborator

I tried to solve #8, but I didn't add unittest for logger. Also I add loguru as an optional dependency with fall back mechanism.

@tavallaie
Copy link
Collaborator Author

intersting, I found some bugs that bypass the tests :D

@tavallaie
Copy link
Collaborator Author

I don't know if it is a bug or not.
@ChuckHend why do we have this in our tests and still it is passing the tests? I don't have a clue here

..2025-10-20 16:13:48,496 - pgmq.async_queue - ERROR - Transaction failed: transactional_create_queue - transactional_create_queue() got an unexpected keyword argument 'conn' | event=transaction_error | function=transactional_create_queue | error_type=TypeError | error_message=transactional_create_queue() got an unexpected keyword argument 'conn' | conn_id=139933109644304
.2025-10-20 16:13:48,549 - pgmq.async_queue - ERROR - Transaction failed: transactional_operation - transactional_operation() got an unexpected keyword argument 'conn' | event=transaction_error | function=transactional_operation | error_type=TypeError | error_message=transactional_operation() got an unexpected keyword argument 'conn' | conn_id=139933109896288

@ChuckHend
Copy link
Contributor

@tavallaie , I see that too. Maybe something broke when we ported the CI over?

@tavallaie
Copy link
Collaborator Author

tavallaie commented Oct 21, 2025

@ChuckHend, I didn't see it in last action before I adding logger to the decorator so I will revert it to find if it is related to my changes or not.

@tavallaie
Copy link
Collaborator Author

OK, my decorator.py changes can bypass the tests, so I’ll go with Plan B.
I’ll fix some minor styling issues on the main branch and publish a new version on PyPI.
Then I’ll work on more unit tests and come back to this enhancement later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants