If outerContext is nil we do not return self sender anymore #18422
+27
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
force-pushed
the
18387-Binding-of-arguments-does-not-work-well-with-nested-clean-blocks
branch
from
7f79e72 to
50c090f
Compare
jecisc
added
the
Status: Need more work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #18387.
When trying to access a variable located in the outerContext of a block context if the block is clean it may happen that the value is not available.
The current implementation traverse the stack trying to find the outerContext but it does not correctly works in many case.
This PR proposes to remove the guessing and raise an exception if the block is clean, the UI traps that and shows it nicely.