Skip to content

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jul 31, 2025

Fix #1770

Related to docker-library/php#1596, will also require Golang Trixie image when available

@GreyXor
Copy link

GreyXor commented Aug 12, 2025

php debian trixie just got merged docker-library/php#1596

@alexandre-daubois alexandre-daubois force-pushed the debian-trixie branch 2 times, most recently from 205c16e to 9bc661e Compare August 13, 2025 06:54
@AlliBalliBaba
Copy link
Contributor

Looks like there isn't a golang-trixie yet, probably would still work if the go binary is just copied from the bookworm image.

@GreyXor
Copy link

GreyXor commented Aug 13, 2025

Looks like there isn't a golang-trixie yet, probably would still work if the go binary is just copied from the bookworm image.

Should be available soon
docker-library/golang#564

@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Aug 13, 2025

I wanted to wait for golang new image indeed. Let's wait for docker-library/official-images#19675 to be merged and I'll attempt a new build

@henderkes
Copy link
Contributor

Looks good, but is there actually a strong reason to use Debian over Ubuntu or vice versa? In a Docker container, I mean.

@alexandre-daubois
Copy link
Member Author

Debian is more stable than Ubuntu (who's based on the unstable branch of Debian). Also, official PHP images use Debian, so it seems better to stick with it.

Copy link
Contributor

@AlliBalliBaba AlliBalliBaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main benefit of debian is that some issues are already fixed upstream (and install-php-extensions).

@GreyXor
Copy link

GreyXor commented Aug 15, 2025

Built and tested the trixie image. Working good for me 👍 Just like bookworm

@AlliBalliBaba
Copy link
Contributor

AlliBalliBaba commented Aug 19, 2025

We can merge this whenever you're ready @dunglas . Something to keep in mind is that the new default will be trixie, not bookworm. If you plan to release a new major version with this, give a heads up since I also have another small breaking change that I wanted to do.

@dunglas
Copy link
Member

dunglas commented Aug 23, 2025

Thanks for working on this!

I don't plan to release a new major of FrankenPHP yet. "Official" PHP images also change the default Debian version when a new version is released, so it looks ok to me as long as we are on sync with official images.

Regarding the other change, isn't an upgrade path possible?

@AlliBalliBaba
Copy link
Contributor

AlliBalliBaba commented Aug 23, 2025

The other change is just for library users, since I intend to remove 'NewRequestWithContext' (nothing wild).

I recently also tried the trixie image and it looks like in most cases downstream users won't even notice the upgrade since there are mostly no adjustments needed.

@henderkes
Copy link
Contributor

The only "upgrade path" for users would be to specify what OS their containers are based on if it matters for .deb packages.

Anything a user would compile/download themselves wouldn't run into issues, given that Trixie uses a newer glibc version.

@lukasamd
Copy link

If I can add something as topic observer - it will be really nice to have FrankenPHP based on Trixie

Our example: Trixie image provides postgresql-client for v17, so we do not need to add external repo and then install from it. The same applies to few other packages

@grs93-svg
Copy link

We testing it since 1 week. Works good . ✅ we found no issues.

If I can add something as topic observer - it will be really nice to have FrankenPHP based on Trixie

Our example: Trixie image provides postgresql-client for v17, so we do not need to add external repo and then install from it. The same applies to few other packages

Yes! trixie is very useful because it have some new packages directly in repos. like valkey-server

@dunglas When this can be merged ? Do we miss something ?

Thanks all

@AlliBalliBaba
Copy link
Contributor

CI failures are just the random failure I have fixed again by moving the test back in #1814

@dunglas dunglas merged commit c14d771 into php:main Aug 27, 2025
37 of 56 checks passed
@dunglas
Copy link
Member

dunglas commented Aug 27, 2025

Thanks!!

henderkes pushed a commit to static-php/frankenphp that referenced this pull request Sep 11, 2025
* ci: add support for Debian Trixie

* nit

* add Trixie to bug_report.yaml

---------

Co-authored-by: Kévin Dunglas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Debian 13 (Trixie) support
7 participants