Refactor benchmarks #363
Refactor benchmarks #363
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 50 50
Lines 5057 5057
Branches 573 573
=======================================
Hits 4196 4196
Misses 853 853
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the benchmarking infrastructure by replacing a custom benchmark submodule with Google Benchmark, consolidating scattered benchmark code into a centralized structure, and improving the build system configuration.
- Removes custom benchmark submodule and old benchmark implementations
- Adopts Google Benchmark framework with standardized benchmark files
- Consolidates CMake configuration with improved build options and CI integration
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| extern/benchmark | Removed custom benchmark submodule |
| benchmark/CMakeLists.txt | Replaced with unified CMake config using FetchContent for Google Benchmark |
| benchmark/Bench_*.cpp | New standardized benchmarks using Google Benchmark API |
| benchmark/Street/, benchmark/Graph/, benchmark/Dynamics/ | Removed old benchmark directories and implementations |
| CMakeLists.txt | Added DSF_BENCHMARKS option and Profile build type |
| examples/CMakeLists.txt | Added profiling support with -pg flag |
| .gitmodules | Removed benchmark submodule reference |
| .github/workflows/cmake_tests.yml | Removed unused dependency installations |
| .github/workflows/benchmark_release.yml | New CI workflow for benchmark execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| elseif(CMAKE_BUILD_TYPE MATCHES "Profile") | ||
| if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Ofast -march=native -flto=auto -pg") | ||
| endif() |
There was a problem hiding this comment.
The Profile build type uses -march=native which creates binaries optimized for the build machine's CPU architecture. This can cause portability issues if binaries are distributed. Consider documenting this limitation or using a separate option to enable -march=native for profiling.
No description provided.