-
-
Notifications
You must be signed in to change notification settings - Fork 226
Update WEBPASSWORD_FILE file example with permissions information #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CI tests are failing with
|
Updates the WEBPASSWORD_FILE with required permissions settings. These permissions settings are not well documented in the online Docker Secrets examples. Signed-off-by: Bradley G Smith <[email protected]>
Thanks! Sorry I missed the failing CI tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to replicate the the failing with wrong UID/GID and docker compose but it worked anyway.
On the host
chris@T14Gen5:~/Downloads/piv6$ ls -lha ./pihole_password.txt
-r-------- 1 1001 1001 9 Feb 25 09:14 ./pihole_password.txt
Within the container
816698bbc2a4:/# ls -lha /run/secrets/
total 12K
drwxr-xr-x 2 root root 4.0K Jul 28 11:48 .
drwxr-xr-x 1 root root 4.0K Jul 28 11:48 ..
-r-------- 1 1001 1001 9 Feb 25 08:14 pihole_webpasswd
Log output
chris@T14Gen5:~/Downloads/piv6$ docker compose up
Attaching to pihole
pihole | [i] Setting up user & group for the pihole user
pihole | [i] PIHOLE_UID not set in environment, using default (1000)
pihole | [i] PIHOLE_GID not set in environment, using default (1000)
pihole |
pihole | [i] Starting FTL configuration
pihole | [i] Setting FTLCONF_webserver_api_password from file
pihole | [i] Assigning password defined by Environment Variable
Maybe because my local user is part of the docker
group?
I suspect that is the reason but not sure. I tested this using docker on a synology where there isn't a docker group. I will spin up a fedora vm later today and test. Off hand I am puzzled that in the container the pihole UID (1000) could read the secrets file which has a UID of 1001 and is read-only to that UID. Useful info at: docker/compose#12362 |
Maybe someone from @pi-hole/docker-maintainers can test as well. |
Updates the WEBPASSWORD_FILE with required permissions settings. These permissions settings are not well documented in the online Docker Secrets examples.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)