Added autocomplete of mail addresses to attendees in event editor in interactive mode. #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elected contact missing
for more information, see https://pre-commit.ci
mschilli87
reviewed
Dec 16, 2023
khal/settings/khal.spec
Outdated
| # since it has only been developed with khard in mind - but other providers | ||
| # should be configurable to create the same output, or the parser could | ||
| # be extended (see _contacts_update in CalenderCollection in khalendar.py) | ||
| address_adapter = string(default=None) |
There was a problem hiding this comment.
What behaviour does None cause and why not default to khard email | tail -n +2?
There was a problem hiding this comment.
None causes no autocompletion to be available (no address book). The idea behind not setting the default to khard email was that not everyone might have khard installed.
However, I agree that this is counterintuitive. I have committed a change that:
- Adds an address_adapter field to the [default] section that
- Is, by default,
khard email | tail -n +2 - Can be
None, meaning "empty address book"
- Is, by default,
- Adds the possible value "default" (which is also the default) to the address_adapter in the account section. That value causes the address_adapter from the [default] section to be used for that calendar
- Tests whether the command from address_adapter was run successfully. If that is not the case, the effect is the same as setting address_adapter to
None, i.e. the address book is assumed to be empty.
Does that make more sense?
for more information, see https://pre-commit.ci
…ult] section as global adapter
for more information, see https://pre-commit.ci
|
Thanks for your contribution, @dabrowskiw! This sounds like a very useful feature! Some notes: For me, the attendee widget doesn't have a leading 'Attendee' anymore and I believe that text field should be labeled. 
I would liket to drop the ruff commit, it adds a lot of noise which makes reviewing the PR harder. (I rebased this PR on master and dropped the ruff commit, see https://github.com/pimutils/khal/tree/rebase_pr1324 ) |
|
So I've been trying to use this and make it work for two days, but keep running into a breaking issue. I forked the code and used When I save an event (new or existing), even with no other changes, ikhal dies with the following error: Switching back to the System is EndeavourOS (Arch distro) with the Zen kernel (6.16.5) and running Python 3.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added autocompletion of attendees in the event editor.
This works by exposing an additional configuration option "address_adapter" in the account section. The command specified there is run on startup using "bash -c" and the input is parsed as the contacts for that account. The parser (in CalendarCollection, in _contacts_update()) is written under the assumption that "address_adapter" will be "khal email | tail -n +2", however I am sure other contact managers can be forced to output in the same format, or the parser can be extended to be more intelligent.
The autocomplete (in attendeewidget.py) is using IndicativeListBox from additional_urwid_widgets (available via pip, pyproject.toml updated accordingly) to display autocomplete options and some ugly hackery to pretend that focus is still on the address line while it actually is in the list.
All tests run, and I suspect that the autogenerated configspec.rst should include the comment from khal.spec where I explained how address_adapter works - I am not sure though since I am not familiar with Sphinx and was not able to divine how the Makefile generated the configspec.rst file.
This code is not going to win any beauty contests, the best I can do is hope that only a few of those who look at it will need PTSD treatment. However, this is a development driven by need and not by too much spare time, so I am afraid that it's either "share it now" or "share it when it's cleaned up, which may well be never". If you think the usefulness of the feature outweighs the ugliness of the code, I am more than happy to contribute, but I will not be offended if you don't.
Anyways, thanks for the great tool that khal is, I very much enjoy working with it :)