Skip to content

Add "todo edit --description" for comfy editing in external editor #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add "todo edit --description" for comfy editing in external editor #312

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f80f886
Add "todo edit --description" for comfy editing in external editor
hut May 19, 2018
00e9929
Fix description being reset with `--description`
hut May 19, 2018
7f0f5ba
Do a `str.strip()` after using `--description`, for consistency
hut May 19, 2018
1a89920
Avoid interactive editing after --description when text unchanged
hut May 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion todoman/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,18 @@ def new(ctx, summary, list, todo_properties, read_description, interactive):
"Only use this if you REALLY know what you're doing!"
)
)
@click.option(
'--description',
is_flag=True,
help=(
'Edit the description in an external editor.'
)
)
@_todo_property_options
@_interactive_option
@with_id_arg
@catch_errors
def edit(ctx, id, todo_properties, interactive, raw):
def edit(ctx, id, todo_properties, interactive, raw, description):
'''
Edit the task with id ID.
'''
Expand All @@ -403,6 +410,15 @@ def edit(ctx, id, todo_properties, interactive, raw):
changes = True
setattr(todo, key, value)

if description:
if interactive is None:
interactive = False
old_description = todo.description
new_description = click.edit(todo.description)
if new_description is not None and old_description != new_description:
todo.description = new_description.strip()
changes = True

if interactive or (not changes and interactive is None):
ui = TodoEditor(todo, ctx.db.lists(), ctx.ui_formatter)
ui.edit()
Expand Down