Use a defined sourceTime when using parsedatetime #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the parsedatetime functionalities freezegun is not used to compute the source time. If the tests are run too close to midnight it might result in the computation of 'tomorrow' being another day then now() + 24h (because time.localtime() will be the next day) … thus failing test_default_due2. Setting sourceTime when calling parsedatime will ensure the same base is used for all tests.
|
AFAICT this should fix #320 |
|
I'd rather decorate affected tests, and keep non-test code as is in this case. Do you know exactly which tests are affected by this? |
|
* Hugo Osvaldo Barrera [2019-08-26 16:17:23]:
I'd rather decorate affected tests, and keep non-test code as is in this case.
Do you know exactly which tests are affected by this?
test_default_due2 and I just noticed that it fails also at this time
and hour when the timezone is CEST but on the second test:
assert todos['ccc'].due == todos['bbb'].due - datetime.timedelta(hours=23)
(it does not fail with "my" patch though)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the parsedatetime functionalities freezegun is not used to
compute the source time. If the tests are run too close to midnight it
might result in the computation of 'tomorrow' being another day then
now() + 24h (because time.localtime() will be the next day) … thus
failing test_default_due2.
Setting sourceTime when calling parsedatime will ensure the same base is
used for all tests.