Add NADA implementation #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 79.30% 79.29% -0.02%
==========================================
Files 51 56 +5
Lines 2460 2748 +288
==========================================
+ Hits 1951 2179 +228
- Misses 419 470 +51
- Partials 90 99 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This change adds the NADA congestion control implementation. The binding to cc is left TODO.
Hi! Is there some problems with implementation? Feature looks so good but hasn't been pushed in master yet :( |
|
I’ve used the code before in production. Actually it works quite well and
can often be more stable for higher bitrate use cases.
I didn’t have the time to get it working with the interceptor library back
then, a contribution would be welcome!
…On Tue, Sep 16, 2025 at 5:47 AM Krage56 ***@***.***> wrote:
*Krage56* left a comment (pion/interceptor#117)
<#117 (comment)>
@kevmo314 <https://github.com/kevmo314> This is great, thanks for
implementing it! Sorry I didn't get to review/test this earlier! I started
#149 <#149> now to integrate it
into interceptors and will try to find some time to review the code and
understand NADA better.
Hi! Is there some problems with implementation? Feature looks so good but
hasn't been pushed in master yet :(
—
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD423RP45KUDGFD3OYBFP33S7MDVAVCNFSM6AAAAACGUGLQE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOJXGIYDENJZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the NADA congestion control implementation.
The binding to cc is left TODO.