Remove remaining usage of OpenAILLMContext throughout the codebase …
#2735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in favor of `LLMContext`, except for: - Usage in classes that are already deprecated - Usage related to realtime LLMs, which don't yet support `LLMContext` - Usage in (soon-to-be-deprecated) code paths related to `OpenAILLMContext` itself and associated machinery
kompfner
commented
Sep 24, 2025
| {"role": "user", "content": " How is the weather today in San Francisco, California?"}, | ||
| ] | ||
| context = OpenAILLMContext(messages, standard_tools()) | ||
| # This is done by default inside the create_context_aggregator |
There was a problem hiding this comment.
Using universal LLMContext let us get rid of this hack 👍
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
kompfner
commented
Sep 24, 2025
| async def _test_llm_function_calling(llm: LLMService): | ||
| # Create an AsyncMock for the function | ||
| mock_fetch_weather = AsyncMock() | ||
| # Create a mock weather function |
There was a problem hiding this comment.
I changed the way we're mocking the function to avoid this unit test printing a deprecation warning.
The issue was that the AsyncMock()'s signature didn't match the single-FunctionCallParams-argument signature our code is expecting. Our code would then assume it was a deprecated old-style function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in favor of
LLMContext, except for:LLMContextOpenAILLMContextitself and associated machinery