DailyTransport: deprecated DailyUpdateRemoteParticipantsFrame #2742
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
aconchillo
force-pushed
the
aleix/deprecate-daily-update-remote-participants-frame
branch
from
4899649 to
85ea1a3
Compare
vipyne
reviewed
Sep 30, 2025
CHANGELOG.md
Outdated
Comment on lines
17
to
19
| future version. Create your own custom frame and use a custom processor to | ||
| handle it or use, for example, `on_after_push_frame` event instead in the | ||
| output transport. |
There was a problem hiding this comment.
wording nit
Suggested change
| future version. Create your own custom frame and use a custom processor to | |
| handle it or use, for example, `on_after_push_frame` event instead in the | |
| output transport. | |
| future version. Create your own custom frame and handle it in the | |
| `@transport.output().event_handler("on_after_push_frame")` event handler | |
| or a custom processor. |
There was a problem hiding this comment.
Thank you. Done!
vipyne
reviewed
Sep 30, 2025
| warnings.simplefilter("always") | ||
| warnings.warn( | ||
| "DailyUpdateRemoteParticipantsFrame is deprecated and will be removed in a future version." | ||
| "Create your own custom frame and use a custom processor to handle it or use, for example, " |
vipyne
approved these changes
Sep 30, 2025
markbackman
approved these changes
Sep 30, 2025
aconchillo
force-pushed
the
aleix/deprecate-daily-update-remote-participants-frame
branch
from
85ea1a3 to
cf2c9d3
Compare
aconchillo
force-pushed
the
aleix/deprecate-daily-update-remote-participants-frame
branch
from
cf2c9d3 to
92d3be8
Compare
aconchillo
deleted the
aleix/deprecate-daily-update-remote-participants-frame
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
This PR deprecates
DailyUpdateRemoteParticipantsFrame. Developers can create their own custom frame and add a custom processor after the base output transport, or use on of the new events like, for example,on_after_push_framein the output transport.The main reason is to avoid having to support one frame per function and the corresponding handling of that frame.