-
Notifications
You must be signed in to change notification settings - Fork 272
fix: made number of responses count dynamic #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: made number of responses count dynamic #222
Conversation
Thank you for following the naming conventions! 🙏 |
This fix represented visually : Also referenced the count reponses as a link, which redirects to testimonials section. Allowing easier navigation and more intuitive usability. Loom link : https://www.loom.com/share/f733e00bf20f4c739a50053ec8e3e1ef?sid=e6daa078-c58a-48ba-861b-bcbbd4535b07 |
Removed the unnecessary console.log, which was used for testing.
Hey there, there is a merge conflict, can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts!
const projectId = project?.id || "" | ||
const { data: formResponses } = useGetFormResponsesByProjectId(projectId) | ||
|
||
const getResponseCount = (formId: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wrap this in useMemo()
hook
</span> | ||
<span className="flex items-center gap-1 truncate text-sm text-gray-500"> | ||
0 responses. Created{' '} | ||
<Link href="/dashboard/web/testimonials" className="underline"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle the check for 0 responses also,
if the value of responses is 0 then show the 0 responses
text else the <Link>
component
Hey @thejediboySHASHANK are you working on the requested changes? |
Yes! Sorry for the delay, I will soon be making a commit to fix these issues. |
What does this PR do?
Fixes issue #221
Fixes #221
The fixed issue correctly displays the number of responses submitted to a particular form.
Also, the number of forms has been underlined, referencing it as a link for easier navigation to see all the submitted response. Making the front-end experience more intuitive and easier to use.
@hemantwasthere