Skip to content

fixed loop named variable #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fixed loop named variable #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a0cb09
changed plan from 53 to 57
daviddelikat Feb 22, 2012
1612067
assign default empty array to priv properties
daviddelikat Feb 23, 2012
e6535e4
removed WebGUI::Utility and WebGUI::Cache because they no longer exis…
daviddelikat Feb 23, 2012
fec47c1
fixed test for approval
daviddelikat Feb 23, 2012
2274bd5
use correct name to get auth instance
daviddelikat Feb 24, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/WebGUI/Middleware/WGAccess.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ sub call {
else {
$privs = JSON->new->utf8->decode($contents);
}
# in some cases there is nothing but state; default each list to an empty array
$privs->{user} ||= [ ];
$privs->{groups} ||= [ ];
$privs->{assets} ||= [ ];

return @$r = (403, [ 'Content-Type' => 'text/plain' ], [ 'Forbidden' ])
if $privs->{state} eq 'trash';
Expand Down
2 changes: 1 addition & 1 deletion lib/WebGUI/Operation/Settings.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ sub www_editSettings {

# Get fieldsets for avaiable auth methods
foreach my $authName (@{$session->config->get("authMethods")}) {
my $authInstance = WebGUI::Operation::Auth::getInstance($session,$_,1);
my $authInstance = WebGUI::Operation::Auth::getInstance($session,$authName,1);
$tabform->getTab( "auth" )->addFieldset( $authInstance->editUserSettingsForm, name => $authName, label => $authName );
}

Expand Down
2 changes: 1 addition & 1 deletion t/Asset/EMSSubmissionForm.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ $sub1 = $sub1->cloneFromDb;
diag $sub1->submissionStatus;
diag $sub1->ticketId;
diag $sub1->getRevisionCount;
is( $sub1->get('submissionStatus'),'created','approval successfull');
is( $sub1->get('submissionStatus'),'approved','approval successfull');

my $ticket = eval { WebGUI::Asset->newById($session, $sub1->get('ticketId')); };
my $e = Exception::Class->caught();
Expand Down
2 changes: 1 addition & 1 deletion t/Asset/Wobject/Survey.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ my $session = WebGUI::Test->session;

#----------------------------------------------------------------------------
# Tests
plan tests => 53;
plan tests => 57;

#----------------------------------------------------------------------------
# put your tests here
Expand Down
2 changes: 0 additions & 2 deletions t/Group/ldap_groups.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@ use lib "$FindBin::Bin/../lib";

use WebGUI::Test;
use WebGUI::Session;
use WebGUI::Utility;

use WebGUI::User;
use WebGUI::Group;
use WebGUI::Cache;

use Test::More skip_all => 'Disabled until the test LDAP server is rejuvenated';
use Test::Deep;
Expand Down