Skip to content

Remove now superfluous props.path for '404' and 'WP Form Completions' #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Remove now superfluous props.path for '404' and 'WP Form Completions' #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/src/js/integrations/form-submit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ document.addEventListener('DOMContentLoaded', () => {
* Send a custom event to Plausible.
*/
trackSubmission: function () {
plausible(plausible_analytics_i18n.form_completions, {'props': {'path': document.location.pathname}});
plausible(plausible_analytics_i18n.form_completions);
}
};

Expand Down
2 changes: 1 addition & 1 deletion assets/src/js/integrations/form-submit.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 1 addition & 14 deletions src/Actions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,22 +71,9 @@ public function maybe_register_assets() {

// Track 404 pages (if enabled)
if ( Helpers::is_enhanced_measurement_enabled( '404' ) && is_404() ) {
$data = wp_json_encode(
[
'props' => [
'path' => 'document.location.pathname',
],
]
);

/**
* document.location.pathname is a variable. @see wp_json_encode() doesn't allow passing variable, only strings. This fixes that.
*/
$data = str_replace( '"document.location.pathname"', 'document.location.pathname', $data );

wp_add_inline_script(
'plausible-analytics',
"document.addEventListener('DOMContentLoaded', function () { plausible( '404', $data ); });"
"document.addEventListener('DOMContentLoaded', function () { plausible( '404' ) });"
);
}

Expand Down