Skip to content

[DO NOT MERGE] Visual Regression Testing with Percy Example #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Visual Regression Testing with Percy Example #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Example/SampleComponent/Apple - Working with UI Controls/CategoryRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ public struct CategoryRow: View {
public struct CategoryItem: View {
public var landmark: Landmark
public var body: some View {
VStack(alignment: .leading) {
VStack {
landmark.image
.renderingMode(.original)
.resizable()
.frame(width: 155, height: 155)
.cornerRadius(5)
.cornerRadius(155 / 2)
Text(landmark.name)
.foregroundColor(.primary)
.font(.caption)
Expand Down
2 changes: 1 addition & 1 deletion Example/SampleComponent/Apple - Working with UI Controls/Home.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public struct CategoryHome: View {
Text("See All")
}
}
.navigationBarTitle(Text("Featured"))
.navigationBarTitle(Text("Home"))
.navigationBarItems(trailing: profileButton)
.sheet(isPresented: $showingProfile) {
ProfileHost()
Expand Down
2 changes: 1 addition & 1 deletion Example/SampleComponent/Apple - Working with UI Controls/LandmarkDetail.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public struct LandmarkDetail: View {
VStack {
MapView(coordinate: landmark.locationCoordinate, didFinishRendering: didFinishRendering)
.edgesIgnoringSafeArea(.top)
.frame(height: 300)
.frame(height: 320)

CircleImage(image: landmark.image)
.offset(x: 0, y: -130)
Expand Down
2 changes: 1 addition & 1 deletion Example/SampleComponent/Apple - Working with UI Controls/Models/Profile.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public struct Profile {
Profile(
username: "g_kumar",
prefersNotifications: true,
seasonalPhoto: .winter,
seasonalPhoto: .summer,
goalDate: goalDate
)
}
Expand Down
2 changes: 1 addition & 1 deletion Example/SampleComponent/Apple - Working with UI Controls/Profiles/HikeBadge.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public struct HikeBadge: View {
Badge()
.frame(width: 300, height: 300)
.scaleEffect(1.0 / 3.0)
.frame(width: 120, height: 120)
.frame(width: 130, height: 130)
Text(name)
.font(.caption)
.accessibility(label: Text("Badge for \(name)."))
Expand Down
2 changes: 1 addition & 1 deletion Example/SampleComponent/Apple - Working with UI Controls/Supporting Views/LandmarkRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public struct LandmarkRow: View {
if landmark.isFavorite {
Image(systemName: "star.fill")
.imageScale(.medium)
.foregroundColor(.yellow)
.foregroundColor(.red)
}
}
}
Expand Down