Skip to content

Conversation

@XYenChi
Copy link
Collaborator

@XYenChi XYenChi commented Apr 18, 2025

Removed maskedoff parameter

Removed maskedoff parameter
@lazyparser
Copy link
Member

这是一个非常大的修改。有没有办法拆分成更加小的修改?

Copy link
Member

@lazyparser lazyparser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve w/ comments

有几个修复的要求,后续可以补充pr或者修改pr

auto maskedoff = getMaskedoff(op);
if (maskedoff)
maskedoff->typeInfo = vd->typeInfo;
// auto maskedoff = getMaskedoff(op);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉,而不是注释之

parser.add_argument('--node', type=int, default=10,
help='Minimal # of node')
parser.add_argument('--length', type=int, default=500,
parser.add_argument('--length', type=int, default=5,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在另一个pr中已经被merge了?

} else
dataOut[i] = dataMO[i];
}
// else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉而不是注释

@lazyparser
Copy link
Member

@XYenChi XYenChi marked this pull request as draft April 19, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants