-
Couldn't load subscription status.
- Fork 1
Trim to vsbc and vdiv to test CI #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Removed maskedoff parameter
|
这是一个非常大的修改。有没有办法拆分成更加小的修改? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve w/ comments
有几个修复的要求,后续可以补充pr或者修改pr
| auto maskedoff = getMaskedoff(op); | ||
| if (maskedoff) | ||
| maskedoff->typeInfo = vd->typeInfo; | ||
| // auto maskedoff = getMaskedoff(op); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删掉,而不是注释之
| parser.add_argument('--node', type=int, default=10, | ||
| help='Minimal # of node') | ||
| parser.add_argument('--length', type=int, default=500, | ||
| parser.add_argument('--length', type=int, default=5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在另一个pr中已经被merge了?
| } else | ||
| dataOut[i] = dataMO[i]; | ||
| } | ||
| // else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删掉而不是注释
Removed maskedoff parameter