[DO NOT MERGE] sync for review #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Port CustomOperator.def. 2. Add rounding mode. 3. Port tail policy. 4. Add intrinsic function prefix "__riscv_". 5. Fix CI.
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces extensive inline comment additions and new literal body definitions across multiple operator literal generation scripts. Key changes include the introduction of new operation modes (e.g. FRM, VXRM) in VXLiteral, VVLiteral, VSLiteral, and VLiteral, updates to operator creation functions to include identifying inline comments, and adjustments to build and CI configuration files.
Reviewed Changes
Copilot reviewed 60 out of 68 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/XLiteral.py | Added new literal body for nonmask MV operations and inline comments in create_x_op. |
| scripts/VXMLiteral.py | Appended inline comments to operator creation lines. |
| scripts/VXLiteral.py | Introduced new literal bodies (e.g. vx_literal_nonmask_frm_body, vx_literal_mask_vxrm_body) and extended operator creation branches for FRM/VXRM modes. |
| scripts/VVMLiteral.py | Minor comment additions. |
| scripts/VVLiteral.py | Added several new literal bodies and updated operator creation functions for various modes. |
| scripts/VSLiteral.py | New reduction and masked literal bodies introduced. |
| scripts/VLiteral.py | Added literal bodies for load and frame operations; updated operator creation functions with inline comments and debug outputs. |
| scripts/MiscMaskLiteral.py | Updated inline comments and adjusted input handling in operator creation functions. |
| scripts/GenerateOperatorComputeHeaders.py | Updated header generation comments to reflect the new script location. |
| rif-test | Removed the experimental extension flag from arch_flags. |
| .github/workflows/clang-format.yml | Upgraded the clang-format action version and clangFormatVersion. |
Files not reviewed (8)
- include/Basic.hpp: Language not supported
- include/CustomValue.def: Language not supported
- include/Decode.hpp: Language not supported
- include/TypeInfo.hpp: Language not supported
- library/Basic.cpp: Language not supported
- library/Graph.cpp: Language not supported
- library/Operator.cpp: Language not supported
- library/Utils.cpp: Language not supported
Comments suppressed due to low confidence (2)
rif-test:23
- Verify that the removal of the '-menable-experimental-extensions' flag is intentional and does not negatively impact any functionality relying on experimental extensions.
arch_flags = "-march=%s -mabi=%s " %(opts.arch, opts.abi)
.github/workflows/clang-format.yml:11
- [nitpick] Ensure that upgrading to clang-format version 16 is fully supported by your CI environment and documented for developers.
- uses: DoozyX/[email protected]
| ''' | ||
|
|
||
| v_literal_mask_frm_body = ''' | ||
| // generated by scripts/VLiteral.py v_literal_mask_frm_body |
There was a problem hiding this comment.
Consider removing or guarding the debug std::cerr outputs in this literal body to avoid unintended console logging in production builds.
Suggested change
| // generated by scripts/VLiteral.py v_literal_mask_frm_body | |
| // generated by scripts/VLiteral.py v_literal_mask_frm_body | |
| #ifdef DEBUG |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.