Skip to content

Conversation

iRohitSingh
Copy link

No description provided.

@mister-roboto
Copy link

@iRohitSingh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Jul 3, 2022

Deploy Preview for plone-restapi ready!

Name Link
🔨 Latest commit 1489eb5
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/62c1573344da040009f9b606
😎 Deploy Preview https://deploy-preview-1454--plone-restapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@iRohitSingh
Copy link
Author

@robgietema can you please review and give feedback about this.

@jensens
Copy link
Member

jensens commented Jul 4, 2022

Just some remarks here:

  • plone.app.workflowmanager is an addon - it is neither a dependency of Products.CMFPlone (core) nor of the Plone package
  • I tend to suggest to not add this endpoint to plone.restapi, but keep it within plone.app.workflowmanager package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants