RDS/JDJ/6-12 #1800
Open
RDS/JDJ/6-12 #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claperle
reviewed
Sep 3, 2025
claperle
reviewed
Sep 3, 2025
JacksonJ-KC
force-pushed
the
RDS/JDJ/6-12
branch
from
e096977 to
322dfb0
Compare
claperle
approved these changes
Sep 3, 2025
JacksonJ-KC
force-pushed
the
RDS/JDJ/6-12
branch
from
8b8a80c to
44a3ce3
Compare
supriyagoel
requested changes
Sep 9, 2025
| - Case 1: All interior lighting in the space is controlled by occupancy sensors and modeled via adjustments to the schedules: PASS `if not any(val in ["NONE", "MANUAL_ON", None] for val in occupancy_controls_b): PASS` | ||
| - Case 2: Any interior lighting in the space is missing definitions for occupancy sensor type and schedule adjustments: UNDETERMINED `elif any(val is None for val in occupancy_controls_b) or any(val is None for val in occupancy_sensor_schedules_b): UNDETERMINED` | ||
| - Case 3: Else, at least one interior lighting data group in the space is not controlled by occupancy sensors or modeled via adjustments to the schedules: FAIL `else: FAIL` | ||
|
|
There was a problem hiding this comment.
I do not understand the difference between case 2 and case 3. Looks like case 2 is checking for missing values and case 3 is checking for explicitly set 'No' values?
There was a problem hiding this comment.
Correct, a lot of times Case 2 is not written out explicitly and RCT dev team handles it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.