RDS/KJW/Rule 22-42 #1801
Open
RDS/KJW/Rule 22-42 #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claperle
reviewed
Sep 9, 2025
claperle
approved these changes
Sep 9, 2025
supriyagoel
reviewed
Sep 9, 2025
| - create a list of the expected entering condenser temperatures for the condenser water temperature for the validation calculations - expected_ecwt_temps - units are (F). The values are selected to capture the minimum, maximum, rating condition and some points in between: `expected_ecwt_temps = [60,104,85,72.5,97.5]` | ||
|
|
||
| - get the coefficients for the EIR-f-T curve (IP units) using a table lookup for table J-6. This assumes that the lookup function will return a list with the coefficients in order (C1,C2,...): `eir_f_t_coefficients = table_J_6_lookup(curve_set,"EIR-f-T")` | ||
| - get the coefficients for the CAP-f-T curve (IP units) using a table lookup for table J-6. This assumes that the lookup function will return a list with the coefficients in order (C1,C2,...): `cap_f_t_coefficients = table_J_6_lookup(curve_set,"Cap-f-T")` |
There was a problem hiding this comment.
@JacksonJ-KC does this table_j_6 look up require a data set to be developed or does that dataset already exist?
There was a problem hiding this comment.
@JacksonJ-KC the RDS looks good but we should probably discuss precision out here. the coefficients in App J have 6 significant digits - from what I can tell, we're looking for an absolute match .. which might be unlikely at this level of precision.
There was a problem hiding this comment.
It requires a new data table lookup that @yunjoonjung-PNNL has already taken care of
Agreed - let's discuss precision on the next call
There was a problem hiding this comment.
Yes Right! Thank you for pointing this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous conversation is at #1520