RDS/JDJ/22 43 #1810
RDS/JDJ/22 43 #1810
Conversation
docs/section22/Rule22-43.md
Outdated
| - Case 1: the chiller's minimum part-load ratio and minimum compressor unloading ratio are both equal to 0.25: PASS `if chiller.minimum_load_ratio == 0.25 AND chiller.minimum_unload_ratio == 0.25: PASS` | ||
| - Case 2: either the chiller's minimum part-load ratio or minimum compressor unloading ratio are not defined: UNDETERMINED `elif chiller.minimum_load_ratio == NULL OR chiller.minimum_unload_ratio == NULL: UNDETERMINED` | ||
| - Case 3: else: FAIL: `else: FAIL` | ||
|
|
There was a problem hiding this comment.
this looks good to me- though do we need to check if the curves from app J are used? the rule states 'when using appendix J'.
There was a problem hiding this comment.
(deleted previous response) I gave this more thought, and I agree with you now. My proposed solution is to write a ruleset function that checks if the modeled performance curve align with appendix J and returns a boolean. Rule 22-42 will be adjusted to use the Baseline System type for the applicability check. This rule will have the subfunction checking appendix J added to the applicability check in addition to the Baseline System type.
There was a problem hiding this comment.
App J curves always have to be used for the baseline so why not just update the rule language accordingly to avoid this extra work. As you mention 22-42 already checks if the curves were used so I think that aspect can be excluded from this rule since App J curves are required to always be used it follows logically that the min unload ratio should always be 0.25. To me this just checks a different parameter. Let me know if I am missing something.
There was a problem hiding this comment.
If the simulation tool can't model performance curves, they can model "identical performance" then this minimum ratio requirement would not be applicable.
There was a problem hiding this comment.
P.S. I like the function idea.
There was a problem hiding this comment.
ok, that makes sense. i dont yet see the change for adding a function to check if app J is being used and can review again after that is added.
No description provided.