RS/YJ/Rule 6-13 (2022) (old: 6-12)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "ruleset-checking-tool"
-version = "0.3.1"
+version = "0.4.1"
 description = "PNNL ruleset checking tool"
 authors = ["Weili Xu <[email protected]>", "Charlie Holly <[email protected]>", "Juan Gonzalez <[email protected]>", "Yun Joon Jung <[email protected]>", "Jiarong Xie <[email protected]>", "Jackson Jarbose <[email protected]>", "Karen Walkerman <[email protected]>"]
 license = "MIT"

rct229/__init__.py

@@ -1 +1 @@
-__version__ = "0.3.0"
+__version__ = "0.4.1"

rct229/rulesets/ashrae9012019/__init__.py

@@ -86,6 +86,7 @@
     "prm9012019rule66m62": "section6rule7",
     "prm9012019rule16x33": "section6rule8",
     "prm9012019rule22c86": "section6rule9",
+    "PRM9012019Rule86d29": "section6rule12",
     "prm9012019rule86j27": "section10rule1",
     "prm9012019rule34l50": "section10rule7",
     "prm9012019rule73m45": "section10rule10",

rct229/rulesets/ashrae9012019/section12/section12rule2.py

@@ -173,9 +173,8 @@ def manual_check_required(self, context, calc_vals=None, data=None):
                     auto_receptacle_control_b = calc_vals["auto_receptacle_control_b"]
                     auto_receptacle_control_p = calc_vals["auto_receptacle_control_p"]
                     space_type_b = calc_vals["space_type_b"]
-                    return (
-                        eflh_difference > 0
-                        and (
+                    return eflh_difference > 0 and (
+                        (
                             auto_receptacle_control_p
                             and space_type_b in EXPECTED_RECEPTACLE_CONTROL_SPACE_TYPES
                             and not auto_receptacle_control_b

rct229/rulesets/ashrae9012019/section16/section16rule2.py

@@ -56,13 +56,21 @@ def create_data(self, context, data):
             rmd_p = context.PROPOSED
 
             motor_use_schedule_b = {
-                sch_id: find_exactly_one_schedule(rmd_b, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_b, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_motor_multiplier_schedule", rmd_b
                 )
             }
             motor_use_schedule_p = {
-                sch_id: find_exactly_one_schedule(rmd_p, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_p, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_motor_multiplier_schedule", rmd_p
                 )

rct229/rulesets/ashrae9012019/section16/section16rule3.py

@@ -51,14 +51,22 @@ def create_data(self, context, data):
             rmd_p = context.PROPOSED
 
             cab_ventilation_schedule_p = {
-                sch_id: find_exactly_one_schedule(rmd_p, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_p, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_ventilation_fan_multiplier_schedule",
                     rmd_p,
                 )
             }
             motor_use_schedule_p = {
-                sch_id: find_exactly_one_schedule(rmd_p, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_p, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_motor_multiplier_schedule",
                     rmd_p,

rct229/rulesets/ashrae9012019/section16/section16rule4.py

@@ -51,14 +51,22 @@ def create_data(self, context, data):
             rmd_p = context.PROPOSED
 
             cab_lighting_schedule_p = {
-                sch_id: find_exactly_one_schedule(rmd_p, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_p, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_lighting_multiplier_schedule",
                     rmd_p,
                 )
             }
             motor_use_schedule_p = {
-                sch_id: find_exactly_one_schedule(rmd_p, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_p, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_motor_multiplier_schedule",
                     rmd_p,

rct229/rulesets/ashrae9012019/section16/section16rule5.py

@@ -55,14 +55,22 @@ def create_data(self, context, data):
             rmd_b = context.BASELINE_0
 
             cab_ventilation_fan_multiplier_schedule_b = {
-                sch_id: find_exactly_one_schedule(rmd_b, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_b, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_ventilation_fan_multiplier_schedule",
                     rmd_b,
                 )
             }
             cab_lighting_multiplier_schedule_b = {
-                sch_id: find_exactly_one_schedule(rmd_b, sch_id)["hourly_values"]
+                sch_id: getattr_(
+                    find_exactly_one_schedule(rmd_b, sch_id),
+                    "Schedule",
+                    "hourly_values",
+                )
                 for sch_id in find_all(
                     "buildings[*].elevators[*].cab_lighting_multiplier_schedule", rmd_b
                 )

rct229/rulesets/ashrae9012019/section19/section19rule16.py

@@ -81,7 +81,7 @@ def create_data(self, context, data):
         }
 
         hvac_has_non_mech_cooling_list_p = [
-            getattr_(hvac_p, "HVAC", "cooling_system", "type")
+            hvac_p.get("cooling_system", {}).get("type")
             == COOLING_SYSTEM.NON_MECHANICAL
             for hvac_p in find_all(
                 "$.buildings[*].building_segments[*].heating_ventilating_air_conditioning_systems[*]",

rct229/rulesets/ashrae9012019/section19/section19rule26.py

@@ -6,6 +6,9 @@
     get_hvac_systems_serving_zone_health_safety_vent_reqs,
 )
 from rct229.schema.schema_enums import SchemaEnums
+from rct229.utils.assertions import getattr_
+from rct229.utils.utility_functions import find_exactly_one_schedule
+from rct229.utils.jsonpath_utils import find_all
 from rct229.utils.pint_utils import ZERO
 
 FAN_SYSTEM_OPERATION = SchemaEnums.schema_enums["FanSystemOperationOptions"]
@@ -35,8 +38,20 @@ def create_data(self, context, data):
         applicable_hvac_systems_list_p = (
             get_hvac_systems_serving_zone_health_safety_vent_reqs(rmd_p)
         )
+        fan_operating_schedules_p = {
+            sch_id: getattr_(
+                find_exactly_one_schedule(rmd_p, sch_id), "Schedule", "hourly_values"
+            )
+            for sch_id in find_all(
+                "buildings[*].building_segments[*].heating_ventilating_air_conditioning_systems[*].fan_system.operating_schedule",
+                rmd_p,
+            )
+        }
 
-        return {"applicable_hvac_systems_list_p": applicable_hvac_systems_list_p}
+        return {
+            "applicable_hvac_systems_list_p": applicable_hvac_systems_list_p,
+            "fan_operating_schedules_p": fan_operating_schedules_p,
+        }
 
     class HVACRule(RuleDefinitionBase):
         def __init__(self):
@@ -47,7 +62,6 @@ def __init__(self):
                 required_fields={
                     "$": ["fan_system"],
                     "fan_system": [
-                        "operation_during_unoccupied",
                         "minimum_outdoor_airflow",
                     ],
                 },
@@ -57,15 +71,28 @@ def is_applicable(self, context, data=None):
             hvac_p = context.PROPOSED
             hvac_id_p = hvac_p["id"]
             applicable_hvac_systems_list_p = data["applicable_hvac_systems_list_p"]
+            fan_operating_schedules_p = data["fan_operating_schedules_p"]
+
+            fan_operating_schedule_id_p = hvac_p["fan_system"].get("operating_schedule")
+            if fan_operating_schedule_id_p is not None:
+                fan_operating_schedule_vals_p = fan_operating_schedules_p[
+                    fan_operating_schedule_id_p
+                ]
+                always_on = sum(fan_operating_schedule_vals_p) == len(
+                    fan_operating_schedule_vals_p
+                )
 
-            return hvac_id_p in applicable_hvac_systems_list_p
+            else:
+                always_on = True  # If no schedule is defined, assume always on
+
+            return hvac_id_p in applicable_hvac_systems_list_p and not always_on
 
         def get_calc_vals(self, context, data=None):
             hvac_p = context.PROPOSED
 
-            operation_during_unoccupied_p = hvac_p["fan_system"][
-                "operation_during_unoccupied"
-            ]
+            operation_during_unoccupied_p = getattr_(
+                hvac_p["fan_system"], "FanSystem", "operation_during_unoccupied"
+            )
             minimum_outdoor_airflow_p = hvac_p["fan_system"]["minimum_outdoor_airflow"]
 
             return {

rct229/rulesets/ashrae9012019/section19/section19rule27.py

@@ -6,6 +6,9 @@
     get_hvac_systems_serving_zone_health_safety_vent_reqs,
 )
 from rct229.schema.schema_enums import SchemaEnums
+from rct229.utils.assertions import getattr_
+from rct229.utils.utility_functions import find_exactly_one_schedule
+from rct229.utils.jsonpath_utils import find_all
 from rct229.utils.pint_utils import ZERO
 
 FAN_SYSTEM_OPERATION = SchemaEnums.schema_enums["FanSystemOperationOptions"]
@@ -35,8 +38,20 @@ def create_data(self, context, data):
         applicable_hvac_systems_list_b = (
             get_hvac_systems_serving_zone_health_safety_vent_reqs(rmd_b)
         )
+        fan_operating_schedules_b = {
+            sch_id: getattr_(
+                find_exactly_one_schedule(rmd_b, sch_id), "Schedule", "hourly_values"
+            )
+            for sch_id in find_all(
+                "buildings[*].building_segments[*].heating_ventilating_air_conditioning_systems[*].fan_system.operating_schedule",
+                rmd_b,
+            )
+        }
 
-        return {"applicable_hvac_systems_list_b": applicable_hvac_systems_list_b}
+        return {
+            "applicable_hvac_systems_list_b": applicable_hvac_systems_list_b,
+            "fan_operating_schedules_b": fan_operating_schedules_b,
+        }
 
     class HVACRule(RuleDefinitionBase):
         def __init__(self):
@@ -47,7 +62,6 @@ def __init__(self):
                 required_fields={
                     "$": ["fan_system"],
                     "fan_system": [
-                        "operation_during_unoccupied",
                         "minimum_outdoor_airflow",
                     ],
                 },
@@ -57,15 +71,29 @@ def is_applicable(self, context, data=None):
             hvac_b = context.BASELINE_0
             hvac_id_b = hvac_b["id"]
             applicable_hvac_systems_list_b = data["applicable_hvac_systems_list_b"]
+            fan_operating_schedules_b = data["fan_operating_schedules_b"]
+            always_on = False
+
+            fan_operating_schedule_id_b = hvac_b["fan_system"].get("operating_schedule")
+            if fan_operating_schedule_id_b is not None:
+                fan_operating_schedule_vals_b = fan_operating_schedules_b[
+                    fan_operating_schedule_id_b
+                ]
+                always_on = sum(fan_operating_schedule_vals_b) == len(
+                    fan_operating_schedule_vals_b
+                )
 
-            return hvac_id_b in applicable_hvac_systems_list_b
+            else:
+                always_on = True  # If no schedule is defined, assume always on
+
+            return hvac_id_b in applicable_hvac_systems_list_b and not always_on
 
         def get_calc_vals(self, context, data=None):
             hvac_b = context.BASELINE_0
 
-            operation_during_unoccupied_b = hvac_b["fan_system"][
-                "operation_during_unoccupied"
-            ]
+            operation_during_unoccupied_b = getattr_(
+                hvac_b["fan_system"], "FanSystem", "operation_during_unoccupied"
+            )
             minimum_outdoor_airflow_b = hvac_b["fan_system"]["minimum_outdoor_airflow"]
 
             return {

rct229/rulesets/ashrae9012019/section19/section19rule28.py

@@ -8,6 +8,9 @@
 from rct229.rulesets.ashrae9012019.ruleset_functions.get_hvac_systems_serving_zone_health_safety_vent_reqs import (
     get_hvac_systems_serving_zone_health_safety_vent_reqs,
 )
+from rct229.utils.assertions import getattr_
+from rct229.utils.utility_functions import find_exactly_one_schedule
+from rct229.utils.jsonpath_utils import find_all
 from rct229.schema.schema_enums import SchemaEnums
 
 FAN_SYSTEM_OPERATION = SchemaEnums.schema_enums["FanSystemOperationOptions"]
@@ -43,8 +46,20 @@ def create_data(self, context, data):
                 + get_hvac_systems_serving_zone_health_safety_vent_reqs(rmd_p)
             )
         )
+        fan_operating_schedules_p = {
+            sch_id: getattr_(
+                find_exactly_one_schedule(rmd_p, sch_id), "Schedule", "hourly_values"
+            )
+            for sch_id in find_all(
+                "buildings[*].building_segments[*].heating_ventilating_air_conditioning_systems[*].fan_system.operating_schedule",
+                rmd_p,
+            )
+        }
 
-        return {"inapplicable_hvac_sys_list_p": inapplicable_hvac_sys_list_p}
+        return {
+            "inapplicable_hvac_sys_list_p": inapplicable_hvac_sys_list_p,
+            "fan_operating_schedules_p": fan_operating_schedules_p,
+        }
 
     class HVACRule(RuleDefinitionBase):
         def __init__(self):
@@ -54,25 +69,36 @@ def __init__(self):
                 ),
                 required_fields={
                     "$": ["fan_system"],
-                    "fan_system": [
-                        "operation_during_unoccupied",
-                    ],
                 },
             )
 
         def is_applicable(self, context, data=None):
             hvac_p = context.PROPOSED
             hvac_id_p = hvac_p["id"]
             inapplicable_hvac_sys_list_p = data["inapplicable_hvac_sys_list_p"]
+            fan_operating_schedules_p = data["fan_operating_schedules_p"]
+            always_on = False
+
+            fan_operating_schedule_id_p = hvac_p["fan_system"].get("operating_schedule")
+            if fan_operating_schedule_id_p is not None:
+                fan_operating_schedule_vals_p = fan_operating_schedules_p[
+                    fan_operating_schedule_id_p
+                ]
+                always_on = sum(fan_operating_schedule_vals_p) == len(
+                    fan_operating_schedule_vals_p
+                )
 
-            return hvac_id_p not in inapplicable_hvac_sys_list_p
+            else:
+                always_on = True  # If no schedule is defined, assume always on
+
+            return hvac_id_p not in inapplicable_hvac_sys_list_p and not always_on
 
         def get_calc_vals(self, context, data=None):
             hvac_p = context.PROPOSED
 
-            operation_during_unoccupied_p = hvac_p["fan_system"][
-                "operation_during_unoccupied"
-            ]
+            operation_during_unoccupied_p = getattr_(
+                hvac_p["fan_system"], "FanSystem", "operation_during_unoccupied"
+            )
 
             return {"operation_during_unoccupied_p": operation_during_unoccupied_p}