POD-192 validator network information in podregistry #135
Conversation
| string memory committeeHosts = vm.envString("POD_COMMITTEE_HOSTS"); | ||
|
|
||
| // Split comma-separated host:port pairs | ||
| string[] memory entries = vm.split(committeeHosts, ","); |
There was a problem hiding this comment.
If the env var is empty string "" or has a trailing comma (e.g., "a:1,b:2,"), vm.split yields an empty entry ("") that will fail with invalid host:port entry, which is confusing vs. having an early check for bytes(committeeHosts).length > 0 and having instead an error handling message like "no hosts provided"
There was a problem hiding this comment.
another case, accidental white space, vm.split doesn’t trim; vm.parseUint(" 8080") will likely revert if we let spaces out, say if someone sets "host1:8080, host2:9090" (note the space), parts.length == 2 passes, but vm.parseUint(parts[1]) will revert.
maybe a prior removal of possible spaces beforevm.split could help avoid that
There was a problem hiding this comment.
IPv6 not supported by this split
[2001:db8::1]:8080 would break vm.split(entry, ":") below
No description provided.