Skip to content

Use get_input_type() when checking File Upload and Post Image fields #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use get_input_type() when checking File Upload and Post Image fields #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions includes/Pods_GF.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1803,7 +1803,7 @@ public static function gf_to_pods( $form, $options, $pod = array(), $entry = arr
$value = apply_filters( 'pods_gf_to_pods_value', $value, $field, $field_options, $form, $gf_field, $data, $options );

// If a file is not set, check if we are editing an item.
if ( null === $value && in_array( $gf_field->type, array( 'fileupload', 'post_image' ), true ) ) {
if ( null === $value && in_array( $gf_field->get_input_type(), array( 'fileupload', 'post_image' ), true ) ) {
// If we are editing an item, don't attempt to save.
if ( is_object( $pod ) && $pod->id ) {
continue;
Expand Down Expand Up @@ -3637,7 +3637,7 @@ public static function get_gf_field_value( $value, $params ) {
$value = maybe_unserialize( $value );
}

if ( in_array( $gf_field->type, array( 'post_category', 'post_title', 'post_content', 'post_excerpt', 'post_tags', 'post_custom_field', 'post_image' ) ) ) {
if ( in_array( $gf_field->get_input_type(), array( 'post_category', 'post_title', 'post_content', 'post_excerpt', 'post_tags', 'post_custom_field', 'post_image' ) ) ) {
// Block new post being created in GF
add_filter( 'gform_disable_post_creation_' . $form['id'], '__return_true' );
}
Expand Down Expand Up @@ -3884,7 +3884,7 @@ public static function get_gf_field_value( $value, $params ) {
} else {
$value = null;
}
} elseif ( $handle_files && in_array( $gf_field->type, array( 'fileupload', 'post_image' ), true ) ) {
} elseif ( $handle_files && in_array( $gf_field->get_input_type(), array( 'fileupload', 'post_image' ), true ) ) {
$value = null;

$attachments = array();
Expand Down Expand Up @@ -4212,7 +4212,7 @@ public function _gf_field_validation( $validation_result, $value, $form, $field
$gf_value = self::get_gf_field_value( $value, $gf_params );

// If a file is not set, check if we are editing an item.
if ( null === $gf_value && in_array( $field->type, array( 'fileupload', 'post_image' ), true ) ) {
if ( null === $gf_value && in_array( $field->get_input_type(), array( 'fileupload', 'post_image' ), true ) ) {
// If we are editing an item, return normal result, don't attempt to save.
if ( is_object( $this->pod ) && $this->pod->id ) {
return $validation_result;
Expand Down