-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: Ensure out-of-range integers and other edge case values don't give wrong results for index_of() #24369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itamarst
wants to merge
17
commits into
pola-rs:main
Choose a base branch
from
itamarst:23476-out-of-range-ints-index_of
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+272
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24369 +/- ##
=======================================
Coverage ? 81.81%
=======================================
Files ? 1683
Lines ? 229094
Branches ? 2943
=======================================
Hits ? 187444
Misses ? 40911
Partials ? 739 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b4826f9
to
ddf5907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23476
Previously out-of-range integers would be cast to Null, and then if there was a Null in the series its index would be returned. I.e.
index_of()
was giving wrong results.Now it does the right thing and errors out. Similarly for other cases of lossy casting, not all of which were caught when FirstArgLossLess was first implemented.