-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: Add support for Float16 dtype
#25185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dsprenkels
wants to merge
48
commits into
pola-rs:main
Choose a base branch
from
dsprenkels:float16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to add feature gates now
dsprenkels
commented
Nov 5, 2025
dsprenkels
commented
Nov 5, 2025
dsprenkels
commented
Nov 5, 2025
Member
We have post-read casts, I think that would be fine. This is done when a user passes a f16 dtype as schema. Round tripping without passing a schema is impossible as we don't encode dtypes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changes-dsl
Do not merge if this label is present and red
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for 16-bit floating point types. It creates a
pf16(i.e., "polars f16") newtype (to prevent confusion with otherf16definitions). It is based on thef16type from thehalfcrate, but it is newtype'd such that we canimplan vast amount of traits that we need.Still TODO
[amber] Check if this code is coveredspots are covered by testsBikeshedding suggestions
polars-utilsthe right place to hostpf16?Fixes: #7288
Related: #21803 (not fixed)